Fix tetragon_process_cache_size metric #2827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetragon_process_cache_size metric was increased on every add() and never decreased. This is incorrect - fix it, so that it's increased on add() only if there was no LRU eviction and it's decreased on remove(). Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
lambdanis
added
area/metrics
olsajiri
approved these changes
Aug 23, 2024
| @@ -121,8 +121,9 @@ func (pc *Cache) refInc(p *ProcessInternal) { | |||
| atomic.AddUint32(&p.refcnt, 1) | |||
| } | |||
|
|
|||
| func (pc *Cache) Purge() { | |||
| func (pc *Cache) purge() { | |||
There was a problem hiding this comment.
there's another Purge instance in here..
Line 49 in 95bd823
There was a problem hiding this comment.
The flow is: purge() sends to stopChan, then cacheGarbageCollector() reads from this channel and actually purges the inner lru.Cache (the line you pointed). So metric reset happens in a different goroutine than actual cleanup, but it should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tetragon_process_cache_size metric was increased on every add() and never decreased. This is incorrect - fix it, so that it's increased on add() only if there was no LRU eviction and it's decreased on remove().