tetragon: Assorted fixes #2748
Merged
tetragon: Assorted fixes #2748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding docs for the cgroup rate limit. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Adding docs for the persistent enforcement. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Adding cgroup-rate-map.sh script to display cgroup_rate_map values. It takes argument either ID of the map or its pinned path. Example output: # ./contrib/scripts/cgroup-rate-map.sh id cpu curr prev rate time throttled 31250 0 2 0 2 669596000000000 0 31250 1 1 0 1 669596000000000 0 31250 2 1 0 1 669596000000000 0 31250 3 8 31 20 669594000000000 0 id cpu curr prev rate time throttled 33803 0 1 1 1 669561000000000 0 33803 1 1 4 4 669561000000000 0 33803 2 4 0 4 669559000000000 0 33803 3 2 1 2 669561000000000 0 id cpu curr prev rate time throttled 11218 0 0 0 0 0 0 11218 1 4 0 4 669538000000000 0 11218 2 1 0 1 669561000000000 0 11218 3 1 4 3 669562000000000 0 id cpu curr prev rate time throttled 26 0 1 0 1 669562000000000 0 26 1 5 0 5 669561000000000 0 26 2 0 0 0 0 0 26 3 5 0 5 669538000000000 0 Signed-off-by: Jiri Olsa <jolsa@kernel.org>
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
olsajiri
added
the
release-note/misc
Adding extra log output for max entries for loaded map:
logcapture.go:25: time="2024-07-29T10:22:07Z" level=info msg="tetragon, map loaded." map=tg_stats_map max="{0 false}" ..
logcapture.go:25: time="2024-07-29T10:22:07Z" level=info msg="tetragon, map loaded." map=cgroup_rate_map max="{32768 true}" ...
The value is the configured maximum or zero if it wasn't configured
and stays on default (hardcoded in bpf code).
The bool value is the indicator if the number was configured.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
olsajiri
force-pushed
the
pr/olsajiri/fixes
branch
from
e240572 to
61788b8
Compare
Making sure we evict inactive values from cgroup_rate_map map once per minute. We do have cleanup hook on cgroup_rmdir tracepoint, but we can still end up with leftover records in cgroup_rate_map for quiet cgroups. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
olsajiri
force-pushed
the
pr/olsajiri/fixes
branch
from
61788b8 to
2943ad2
Compare
mtardy
added a commit
that referenced
this pull request
Jul 31, 2024
I was too slow to review #2748 properly and some things could have been enhanced on the docs side. Here are some changes. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
|
Hey 👋 I was too slow so here is my docs review under the form of a PR that you can merge if that suits you! #2760 |
mtardy
added a commit
that referenced
this pull request
Aug 5, 2024
I was too slow to review #2748 properly and some things could have been enhanced on the docs side. Here are some changes. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding missing docs and cgroup rate fixes