Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tetragon: only allow single instance to run on a node #2747

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

inliquid
Copy link
Contributor

Description

This change will make Tetragon fail at startup if it finds out that another instance already created PID file and is still running. Previously it was only logging a warning.

Fixes #2672

This change will make Tetragon fail at startup if it finds out that another instance already created PID file and is still running. Previously it was only logging a warning.

Signed-off-by: Alex In <reexistent@gmail.com>
@inliquid inliquid requested a review from a team as a code owner July 27, 2024 14:09
@inliquid inliquid requested a review from kkourt July 27, 2024 14:09
@mtardy mtardy added the release-note/minor This PR introduces a minor user-visible change label Jul 29, 2024
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm

@jrfastab
Copy link
Contributor

Agree sort of silly to launch if we know its going to be in a bad state.

@jrfastab jrfastab merged commit 9bec45d into cilium:main Jul 30, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't allow Tetragon instance to run when there is another one running
3 participants