Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: update pull request template #2697

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

mtardy
Copy link
Member

@mtardy mtardy commented Jul 19, 2024

Having uncommented "Thanks for contributing! Please ensure your pull request adheres to the following guidelines:" in most PR was generating unnecessary noise. I think it's relevant that the author of a PR sees the guideline and the checklist but maybe it's not relevant to display it every time.

Whether the checklist itself is commented or not can be debated, wdyt?

Having uncommented "Thanks for contributing! Please ensure your pull
request adheres to the following guidelines:" in most PR was generating
unnecessary noise. I think it's relevant that the author of a PR sees the
guideline and the checklist but maybe it's not relevant to display it
every time.

Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
@mtardy mtardy added the release-note/misc This PR makes changes that have no direct user impact. label Jul 19, 2024
@mtardy mtardy requested a review from lambdanis July 19, 2024 09:51
@mtardy mtardy requested a review from a team as a code owner July 19, 2024 09:51
@mtardy
Copy link
Member Author

mtardy commented Jul 22, 2024

CI fixed by #2698, merging this.

@mtardy mtardy merged commit 57fc647 into main Jul 22, 2024
27 of 31 checks passed
@mtardy mtardy deleted the pr/mtardy/pull-request-template-update branch July 22, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants