Makefile: Reduce the amount of vendoring calls #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdanis
added
the
release-note/misc
lambdanis
force-pushed
the
pr/lambdanis/less-vendor
branch
from
c4f32bd to
5633f7e
Compare
When generating Go code for proto API or k8s CRDs, we don't need to run vendoring for all modules before and after. It should be enough if we run vendoring only for the relevant module (api or pkg/k8s) before, and only for the main module after. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
lambdanis
force-pushed
the
pr/lambdanis/less-vendor
branch
from
5633f7e to
ccfd9ea
Compare
mtardy
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating Go code for proto API or k8s CRDs, we don't need to run vendoring for all modules before and after. It should be enough if we run vendoring only for the relevant module (api or pkg/k8s) before, and only for the main module after.