-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate sensors gRPC API #2630
Conversation
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are okay to deprecate since the TracingPolicy can do everything one should need now. Note that the linter doesn't like that we use (our own) deprecated API, we should add a "ignore".
The gRPC sensors interface is the initial interface for manging collections of bpf programs at run-time. It has been replaced by tracing policies. Deprecate the sensor management gRPC calls. Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
A previous commit, deprecated the gRPC sensor API. In this commit, we add directives for the linters to ignore deprecation warnings. Note that the tetra command is already deprecated. Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
84fca41
to
6ca91af
Compare
Thanks, added an ignore. |
Thanks! We moved to TracingPolicy API beforehand so this doesn't affect us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The gRPC sensors interface is the initial interface for manging collections of bpf programs at run-time. It has been replaced by tracing policies. This PR deprecates the sensor management gRPC calls.
Fixes: #1272
CC: @inliquid