Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate sensors gRPC API #2630

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Conversation

kkourt
Copy link
Contributor

@kkourt kkourt commented Jul 4, 2024

The gRPC sensors interface is the initial interface for manging collections of bpf programs at run-time. It has been replaced by tracing policies. This PR deprecates the sensor management gRPC calls.

Fixes: #1272

CC: @inliquid

deprecate sensors gRPC API

@kkourt kkourt added the release-note/minor This PR introduces a minor user-visible change label Jul 4, 2024
@kkourt kkourt requested a review from a team as a code owner July 4, 2024 15:00
@kkourt kkourt requested a review from tixxdz July 4, 2024 15:00
Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 6ca91af
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/6687fa5f23116800085a6b9c
😎 Deploy Preview https://deploy-preview-2630--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are okay to deprecate since the TracingPolicy can do everything one should need now. Note that the linter doesn't like that we use (our own) deprecated API, we should add a "ignore".

kkourt added 3 commits July 5, 2024 15:49
The gRPC sensors interface is the initial interface for manging
collections of bpf programs at run-time. It has been replaced by
tracing policies.

Deprecate the sensor management gRPC calls.

Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
A previous commit, deprecated the gRPC sensor API.
In this commit, we add directives for the linters to ignore deprecation
warnings. Note that the tetra command is already deprecated.

Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
@kkourt kkourt force-pushed the pr/kkourt/deprecate-sensors-grpc-api branch from 84fca41 to 6ca91af Compare July 5, 2024 13:51
@kkourt
Copy link
Contributor Author

kkourt commented Jul 5, 2024

I think we are okay to deprecate since the TracingPolicy can do everything one should need now. Note that the linter doesn't like that we use (our own) deprecated API, we should add a "ignore".

Thanks, added an ignore.

@inliquid
Copy link
Contributor

inliquid commented Jul 5, 2024

Thanks! We moved to TracingPolicy API beforehand so this doesn't affect us.

Copy link
Contributor

@olsajiri olsajiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kkourt kkourt merged commit 4d5a4d7 into main Jul 12, 2024
46 checks passed
@kkourt kkourt deleted the pr/kkourt/deprecate-sensors-grpc-api branch July 12, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecate sensors gRPC interface
4 participants