Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pkg/{cilium,oldhubble} #2580

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Remove pkg/{cilium,oldhubble} #2580

merged 1 commit into from
Jun 27, 2024

Conversation

michi-covalent
Copy link
Contributor

@michi-covalent michi-covalent commented Jun 18, 2024

The option to enable Cilium APIs got removed in #1541. Now it's safe to remove pkg/{cilium,oldhubble} since Tetragon no longer accesses Cilium state.

@michi-covalent michi-covalent added the release-note/misc This PR makes changes that have no direct user impact. label Jun 18, 2024
@michi-covalent michi-covalent changed the title Remove pkg/{cilium,oldhubble} Remove pkg/cilium Jun 18, 2024
@michi-covalent michi-covalent changed the title Remove pkg/cilium Remove pkg/{cilium,oldhubble} Jun 18, 2024
The option to enable Cilium APIs got removed in #1541. Now it's safe to
remove pkg/{cilium,oldhubble} since Tetragon no longer accesses Cilium
state.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent marked this pull request as ready for review June 22, 2024 01:16
@michi-covalent michi-covalent requested a review from a team as a code owner June 22, 2024 01:16
@michi-covalent michi-covalent requested a review from jrfastab June 22, 2024 01:16
Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+12 −48,827

❤️

@michi-covalent michi-covalent merged commit dd47f3d into main Jun 27, 2024
61 of 71 checks passed
@michi-covalent michi-covalent deleted the pr/michi/cleanup branch June 27, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants