pkg/sensors: reduce memory footprint of unused fdinstall maps and various fixes #2563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtardy
added
release-note/bug
mtardy
force-pushed
the
pr/mtardy/fdinstall-map-memory
branch
2 times, most recently
from
5c19dbd to
1b4c684
Compare
olsajiri
reviewed
Jun 18, 2024
Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
Previous condition was buggy and should have been: hasStackTrace = hasStackTrace || KernelStackTrace || UserStackTrace instead of : hasStackTrace = KernelStackTrace || UserStackTrace Using a function simplify this. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
mtardy
force-pushed
the
pr/mtardy/fdinstall-map-memory
branch
from
1b4c684 to
f0189d3
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mtardy
force-pushed
the
pr/mtardy/fdinstall-map-memory
branch
from
f0189d3 to
a44a1fa
Compare
kkourt
approved these changes
Jun 19, 2024
Resize the fdinstall_map if needed to save memory, thus we are saving ~11MB of kernel memory by kprobe that are not using FollowFD, UnfollowFD or CopyFD. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
mtardy
force-pushed
the
pr/mtardy/fdinstall-map-memory
branch
from
a44a1fa to
2631f9b
Compare
mtardy
added
backport-done/1.0
backport-done/1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is not great but it fixes the issue, maybe we can do it more elegantly idk