backport:v1.1: btf: take first entry on multiple function matches #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ OSS upstream 0636406 ] TypeByName() can fail with ErrMultipleMatches if we have multiple candidates. If so, let's try again and take first match as it is. This can help solve our immediate issue of having multiple definitions per system calls, however the long-term fix would be to iterate over all candidate, match their proto and arguments definitions, then attach to the corresponding ones. Example output: time="2024-05-31T15:53:17+01:00" level=info msg="BTF includes '2' matched candidates on call \"__x64_sys_init_module\", using first one" Signed-off-by: Djalal Harouni <tixxdz@gmail.com>
tixxdz
changed the title
tixxdz
added
the
release-note/minor
tpapagian
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ OSS upstream 0636406 ]
TypeByName() can fail with ErrMultipleMatches if we have multiple candidates. If so, let's try again and take first match as it is.
This can help solve our immediate issue of having multiple definitions per system calls, however the long-term fix would be to iterate over all candidate, match their proto and arguments definitions, then attach to the corresponding ones.
Example output:
time="2024-05-31T15:53:17+01:00" level=info msg="BTF includes '2' matched candidates on call "__x64_sys_init_module", using first one"