tetragon: cache username lookups #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tixxdz
added
the
release-note/minor
tixxdz
force-pushed
the
pr/tixxdz/2024-05-cache-usernames
branch
from
c4dc849 to
9b4446c
Compare
kkourt
approved these changes
May 22, 2024
| if userInfo, err := user.LookupId(strconv.FormatUint(uint64(m.Unix.Process.UID), 10)); err == nil { | ||
| m.Unix.Process.User.Name = userInfo.Name | ||
| if username, err := userdb.UsersCache.LookupUser(m.Unix.Process.UID); err == nil { | ||
| m.Unix.Process.User.Name = username |
There was a problem hiding this comment.
would be nice to have a metric here for errors.
There was a problem hiding this comment.
Will do it separately, thanks
|
@tixxdz lookgs good, few questions could you please provide more details in changelogs on why we want to do that, I guess it's faster, can we measure that? thanks |
Cache UIDs/Usernames so we reduce: - I/O on /etc/passwd for each execution especially for root user and other system user IDs as by default lot of software runs under those. - Some users may watch /etc/passwd access, so caching those entries will reduce Tetragon generated events and improve performance overall. We only cache UIDs from 0..999 as these are considered standard system users, that are set by most distros packages. Distros maintainers usually do great job to not clash such users. For anything above > 999 we do not cache it, we can that if users want such support later. Reference: https://github.com/systemd/systemd/blob/main/docs/UIDS-GIDS.md#summary Signed-off-by: Djalal Harouni <tixxdz@gmail.com>
Signed-off-by: Djalal Harouni <tixxdz@gmail.com>
I added the following commit logs: Thank you |
tixxdz
force-pushed
the
pr/tixxdz/2024-05-cache-usernames
branch
from
9b4446c to
79aefef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.