-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve metrics for map and cache sizes #2291
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a more intuitive name. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
tetragon_map_capacity is a constant gauge exposing the capacity of BPF maps. It's useful to be used together with tetragon_map_entries to monitor the map pressure. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
The map capacity is now exaposed by tetragon_map_capacity metric. A separate metric is much easier to use in queries than a label on tetragon_map_entries metric. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
lambdanis
added
area/metrics
Related to prometheus metrics
release-note/minor
This PR introduces a minor user-visible change
labels
Apr 3, 2024
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lambdanis
changed the title
Improve metric for map and cache sizes
Improve metrics for map and cache sizes
Apr 3, 2024
Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
There used to be a wrapper collector defined in the mapmetrics package. It was needed because there were a few packages (mis)using metrics defined there. Now it's cleaned up and only observer uses map metrics, so the wrapper collector is no longer needed. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
lambdanis
force-pushed
the
pr/lambdanis/map-metrics
branch
from
April 3, 2024 22:15
9cc7fd1
to
0b99985
Compare
tetragon_event_cache_entries is a gauge exposing the event cache size. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
There is a metric (tetragon_process_cache_size) defined in the process package, but it wasn't registered in the Prometheus registry, so it wasn't exposed. Fix this and register the metric. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
tetragon_process_cache_capacity exposes the capacity of the process cache. It's useful to be used together with tetragon_process_cache_size to monitor the process cache utilization. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
lambdanis
force-pushed
the
pr/lambdanis/map-metrics
branch
from
April 3, 2024 22:21
0b99985
to
e02d845
Compare
mtardy
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that is a nice package of fixes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/metrics
Related to prometheus metrics
release-note/minor
This PR introduces a minor user-visible change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.
Fixes #1774