-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out bash kubernetes healthchecks #2262
Conversation
Let's cc @willfindlay for more input |
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, thanks!
Still two things please: can you make it in one patch, and investigate the failing CI test as it could be related to your patch?
This patch adds this by removing first argument in exec to correctly compare it to k8s pod's exec probe Signed-off-by: Aliaksei Sofin <sofin.moffin@gmail.com>
@tixxdz I rebased code to one patch, and synced my fork with latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright much appreciated ;-) !
@tixxdz thank you very much! Let's see how CI passes |
@tixxdz well, it failed, now with some transient error in These tests seem rather flaky, maybe try restarting the job? |
This patch adds this by
Fixes: #2261