Git-ignore drop-privileges along with other binaries #2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevsecurity
added
the
release-note/misc
|
I think to fix the checkpatch test you might need to create a new branch from the up to date main and cherry-pick your first commit, and submit that. I think the second commit (the merge) is upsetting the check. |
|
@kevsecurity okay, will do. |
|
@christian-2 equivalent but perhaps easier for you: |
As agreed in PR cilium#2031 Signed-off-by: Christian Hörtnagl <christian2@univie.ac.at>
christian-2
force-pushed
the
fixes-gitignore
branch
from
bdef75e to
30dd955
Compare
|
@kevsecurity Should be fixed now. @willfindlay FYI what appears to have worked for me in the end was |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As agreed in PR #2031. W/o corresponding issue, because change is minor.