metrics: Do not return when we cannot find a _stats map #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpapagian
added
release-note/minor
tixxdz
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Thanks @tpapagian , maybe some log warn only once if the final loadPinnedMap() fails? or maybe doesn't make that much sense ;-)
BTW for issue #1775 there is still that (3) rename map, should be moved to separate issue? so it is not lost.
In Tetragon, we have maps ending with _stats that contain metadata about the main maps. An example is that we have execve_map and execve_map_stats that contains errors and other information related to execve_map map. Now when we fail to open the _stats map, we just stop the loop and we can possibly miss to check for other maps. This patch change that and tries for the next map. Additionally we do not try to collect stats for maps that already end up with _stats as this would result in _stats_stats map names. Signed-off-by: Anastasios Papagiannis <tasos.papagiannnis@gmail.com>
tpapagian
force-pushed
the
pr/apapag/fix_map_metrics
branch
from
8b7b418 to
2c6a42e
Compare
Thanks! Yes, it makes sense. If we see any of these warning we have to fix that. I added a warning there.
OK, I will post a comment to that issue that (1, 2) are fixed by this PR. So I will not close that. |
lambdanis
added
release-note/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Tetragon, we have maps ending with
_statsthat contain metadata about the main maps. An example is that we haveexecve_mapandexecve_map_statsthat contain errors and other information related to theexecve_mapmap.Now when we fail to open the
_statsmap, we just stop the loop and we can possibly miss to check for other maps. This patch changes that and tries for the next map.Additionally, we do not try to collect stats for maps that already end up with
_statsas this would result in_stats_statsmap names.