-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tetragon: run Tetragon without access to CRD #1931
Conversation
558a9dd
to
cd894c7
Compare
/test |
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
9cd7919
to
3bfee91
Compare
I've synced with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good to me. Could you please split the patch into two patches: one for the agent changes, and one for the operator changes?
Sure, done (I've splitted commit) @kkourt did you mean to open separated PR? |
I can't speak for Kornilios but I would say separate commits, so looking all good! |
I mean splitting the commits. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
synced fork |
@aohoyd Can you rebase your branch with cilium:main instead of merging it? It makes the git history easier to read. At the moment the checkpath CI job is failing because of the merge commit (https://github.com/cilium/tetragon/actions/runs/7526335727/job/20488255210?pr=1931). |
@lambdanis sorry, did this via UI. I've reverted merge commit and made a rebase |
I'm not sure, but failed test looks like spontaneous error. Can anyone restart it? |
Tests look all good! ✅ @mtardy, @tpapagian, @lambdanis: do you plan to review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not super-familiar with this part of the codebase, but LGTM! Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small note: if all CRDs are disabled, then I believe Tetragon operator has nothing to do, but it still runs, and there is no way to disable it. Unless someone corrects me, we can update the Helm chart to allow disabling the whole operator in such cases. But this can be a follow-up, not blocking for this PR.
@lambdanis I can do it in separate PR, not a problem. Correct me if I'm wrong:
Didn't I miss something? Is |
Yes. One option is to introduce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding tetragonOperator.enabled
seems reasonable if we want to be able to disable the operator altogether. we can do that as a follow-up PR ✅
Fixes: cilium#1880 Signed-off-by: Alexey Olshanskiy <gh@aohoy.dev>
Fixes: cilium#1880 Signed-off-by: Alexey Olshanskiy <gh@aohoy.dev>
I've added the new flag in #2004 |
Failure in the CI is unrelated #2010 and we can merge this one. |
So I'll merge this, I was just pulled-in by GitHub because of the docs change. |
Fixes #1880
Tetragon
enable-tracing-policy-crd
was added and enabled by defaultTetragon operator
skip-tracing-policy-crd
was added and disabled by defaultHelm chart