Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/option: add metrics-label-filter flags #1678

Merged
merged 1 commit into from
Nov 7, 2023
Merged

pkg/option: add metrics-label-filter flags #1678

merged 1 commit into from
Nov 7, 2023

Conversation

Jack-R-lantern
Copy link
Contributor

@Jack-R-lantern Jack-R-lantern commented Oct 30, 2023 •
edited
Loading

The commit is to add the missing metrics-label-filter flag.

fix: #1667

@netlify
Copy link

netlify bot commented Oct 30, 2023 •
edited
Loading

✅ Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 651c61e
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/654238d183f9700008e8f839
😎 Deploy Preview https://deploy-preview-1678--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jack-R-lantern Jack-R-lantern force-pushed the pr/Jack-R-lantern/tetragon_metrics_label-filter_flag_add branch from eb85c40 to 1f26952 Compare October 31, 2023 00:11
@Jack-R-lantern Jack-R-lantern marked this pull request as ready for review October 31, 2023 00:12
@Jack-R-lantern Jack-R-lantern requested review from mtardy and a team as code owners October 31, 2023 00:12
@lambdanis lambdanis added release-note/bug This PR fixes an issue in a previous release of Tetragon. area/metrics Related to prometheus metrics labels Oct 31, 2023
lambdanis
lambdanis reviewed Oct 31, 2023
View reviewed changes
pkg/option/flags.go Outdated Show resolved Hide resolved
@Jack-R-lantern Jack-R-lantern force-pushed the pr/Jack-R-lantern/tetragon_metrics_label-filter_flag_add branch from 1f26952 to a92c562 Compare November 1, 2023 04:20
@Jack-R-lantern
Copy link
Contributor Author

filter-search
@lambdanis
Checking the documentation, I can't seem to find any information related to filter.
Will it be added later?

@Jack-R-lantern Jack-R-lantern force-pushed the pr/Jack-R-lantern/tetragon_metrics_label-filter_flag_add branch from a92c562 to bb46bde Compare November 1, 2023 04:24
lambdanis
lambdanis requested changes Nov 1, 2023
View reviewed changes
pkg/option/flags.go Outdated Show resolved Hide resolved
@lambdanis
Copy link
Contributor

Checking the documentation, I can't seem to find any information related to filter.
Will it be added later?

@Jack-R-lantern I'm afraid the search in the docs might not work properly. This option is documented in the Helm chart docs, but only there. Do you have suggestions on how to document it better?

@Jack-R-lantern Jack-R-lantern force-pushed the pr/Jack-R-lantern/tetragon_metrics_label-filter_flag_add branch from bb46bde to 2a6721e Compare November 1, 2023 11:33
@Jack-R-lantern
Copy link
Contributor Author

Checking the documentation, I can't seem to find any information related to filter.
Will it be added later?

@Jack-R-lantern I'm afraid the search in the docs might not work properly. This option is documented in the Helm chart docs, but only there. Do you have suggestions on how to document it better?

I think the values.yaml file in the helm chart is sufficient, too
Even for 'standalone', I think "--help" is sufficient.

@Jack-R-lantern
pkg/option: add metrics-label-filter flag
651c61e 
add metrics-label-filter
add example config

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>
@Jack-R-lantern Jack-R-lantern force-pushed the pr/Jack-R-lantern/tetragon_metrics_label-filter_flag_add branch from 2a6721e to 651c61e Compare November 1, 2023 11:38
mtardy
mtardy approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Anna approved this let's merge!

@mtardy mtardy merged commit 1b82079 into cilium:main Nov 7, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtardy mtardy mtardy approved these changes

@lambdanis lambdanis lambdanis approved these changes

Assignees
No one assigned
Labels
area/metrics Related to prometheus metrics release-note/bug This PR fixes an issue in a previous release of Tetragon.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tetragon metrics-label-filter Flags can't set metric-label-filter as an argument
3 participants
@Jack-R-lantern @lambdanis @mtardy