tetragon: ensure struct alignment on startup #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mismatches between the BPF and userspace API are often the cause of bizarre bugs that are difficult to debug. This might happen if a developer makes a change to one and forgets to update the other, or it might simply happen during development if the userspace and BPF targets go out of sync. This PR introduces alignment checks to the Tetragon startup process so that we can fail with a clear error message when such situations arise. Signed-off-by: William Findlay <will@isovalent.com>
willfindlay
added
the
release-note/minor
lambdanis
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mismatches between the BPF and userspace API are often the cause of bizarre bugs that are difficult to debug. This might happen if a developer makes a change to one and forgets to update the other, or it might simply happen during development if the userspace and BPF targets go out of sync. This PR introduces alignment checks to the Tetragon startup process so that we can fail with a clear error message when such situations arise.