ci: minor refactor to build-images job #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to run `make version` in the context of a PR branch, so run it from master before checking out the PR branch. Signed-off-by: William Findlay <will@isovalent.com>
willfindlay
added
area/ci
ferozsalam
approved these changes
Oct 18, 2023
mtardy
reviewed
Oct 18, 2023
| @@ -59,17 +59,26 @@ jobs: | |||
| echo "tag=${{ github.sha }}" >> $GITHUB_OUTPUT | |||
| fi | |||
|
|
|||
| - name: Checkout Source Code | |||
| - name: Checkout master branch | |||
There was a problem hiding this comment.
nit
Suggested change
| - name: Checkout master branch | |
| - name: Checkout main branch |
There was a problem hiding this comment.
Ah nice catch. PR's already merged, but let's fix this in a follow-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to run
make versionin the context of a PR branch, so run it from master before checking out the PR branch.