bugfix: Use shared string maps in kprobe-multi #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpapagian
added
the
release-note/bug
tpapagian
force-pushed
the
pr/apapag/sel_multi_fix
branch
from
f60cccc to
3e1547d
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tpapagian
force-pushed
the
pr/apapag/sel_multi_fix
branch
from
9e6c24d to
d80341d
Compare
Signed-off-by: Anastasios Papagiannis <tasos.papagiannnis@gmail.com>
This test uses a tracing policy with 2 kprobes. Each of them has a selector with 2 filters. Now this test fails in the case of kprobe-multi. The next commit will fix that issue. Only for kernels >= 5.4 as older kernels do not support matchArgs for more than one arguments. Signed-off-by: Anastasios Papagiannis <tasos.papagiannnis@gmail.com>
tpapagian
force-pushed
the
pr/apapag/sel_multi_fix
branch
from
d80341d to
0232844
Compare
kkourt
requested changes
Oct 12, 2023
tpapagian
force-pushed
the
pr/apapag/sel_multi_fix
branch
3 times, most recently
from
c8feb91 to
b4e38d4
Compare
olsajiri
reviewed
Oct 12, 2023
The previous commit shows a test that we have a bug in the case of kprobe-multi, that uses matchArgs where both of these use maps to do equals/prefix/postfix operations. The problem is due to overriding string maps after processing each kprobe. To fix that we use shared maps for all selectors for all attach points in te case of kprobe-multi. Non kprobe-multi cases and tracepoints/uprobes work exactly as before. Signed-off-by: Anastasios Papagiannis <tasos.papagiannnis@gmail.com>
tpapagian
force-pushed
the
pr/apapag/sel_multi_fix
branch
from
b4e38d4 to
e83af73
Compare
olsajiri
approved these changes
Oct 12, 2023
jrfastab
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR first introduces a test showing that we have a bug in the case of kprobe-multi, which uses matchArgs where both use maps to do string operations.
The problem is due to overriding string maps after processing each kprobe. To fix that we use shared maps for all selectors for all attach points in the case of kprobe-multi.
Non kprobe-multi cases and tracepoints/uprobes work exactly as before.