Fix a regression on tetra tracingpolicy enable/disable #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtardy
added
the
release-note/bug
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mtardy
force-pushed
the
pr/mtardy/fix-disable-enable
branch
2 times, most recently
from
0da5bb1 to
2a724dc
Compare
mtardy
commented
Oct 9, 2023
mtardy
force-pushed
the
pr/mtardy/fix-disable-enable
branch
from
2a724dc to
10c6857
Compare
mtardy
force-pushed
the
pr/mtardy/fix-disable-enable
branch
from
10c6857 to
8e637bc
Compare
|
maybe it would be reasonable to add a test covering that regression. |
mtardy
force-pushed
the
pr/mtardy/fix-disable-enable
branch
from
8e637bc to
8867b22
Compare
|
I added a test in c738ea3. |
kkourt
reviewed
Oct 11, 2023
There was a problem hiding this comment.
Thanks! LGTM!
The only thing I'm not sure about is what to do when destroy fails. If we cannot recover from such a case, I'd suggest we just remove the sensor anyway and issue a warning. I'm happy to be convinced otherwise though.
All other comments are just nits.
| // Previously, enabled, filterID and error were bundled in a | ||
| // string. To have a retro-compatible tetra command, we scan | ||
| // the string. If the scan fails, it means something else | ||
| // might be in Info and we print it. |
There was a problem hiding this comment.
Let's make a note of the version that required this (0.11) so that we can remove it eventually.
mtardy
force-pushed
the
pr/mtardy/fix-disable-enable
branch
3 times, most recently
from
6f7d645 to
77ebd7e
Compare
mtardy
commented
Oct 13, 2023
Comment on lines
+86
to
+91
| // destroy will attempt to destroy all the sensors in a collection | ||
| func (c *collection) destroy() { | ||
| for _, s := range c.sensors { | ||
| s.Destroy() | ||
| } | ||
| } |
Commit 310846e introduced a cleanup of the kprobe table entry on unload, which introduced some issues because unload is using when disabling sensors (that might be re-enabled later). Previous pre and post-hooks are still useful for resources management on unload. The kprobe table entry is added on creation (not load) and then it must be cleaned up on deletion introducing the new sensor.Destroy() method. 'Destroy' expresses the idea that the sensor is not usable past this point and must be recreated to be loaded. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
Add support of enable and disable Tracing Policy in tetra CLI. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
Commands were implemented in a way that most of them would not return an exit code != 0 on error and no messages on success. This fixes the issues for the tracing policy subcommands and cleanup the implem. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
Enable and disable were the only features that were only available trough the sensors command and gRPCs, now that they are implemented in the tracingpolicy interface, let's deprecate/hide the sensors command. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
Previously, enabled, filter_id and error were bundled into the info string. We add new dedicated fields and make the new tetra also retrocompatible with the old API missing those fields by parsing the info string. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
This should make sure the regression #1489 doesn't appear anymore: disabling/enabling broke because we cleaned up the generic kprobe table on unloading, which should have been done only on destroying the probe. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
The testutils Config.TetragonLib (or in the end ConfigDefault.TetragonLib) was never written to the actual option.Config.HubbleLib. We noticed it was done manually all over the place in tests so this commit adds it in TestSensorRun that runs in TestMain. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
mtardy
force-pushed
the
pr/mtardy/fix-disable-enable
branch
from
77ebd7e to
0690282
Compare
kkourt
approved these changes
Oct 13, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1489.
See individual commits, this PR:
PostUnloadHook