Renovate: Ignore digest updates for k8s dependencies #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renovate is configured to ignore minor and major updated of k8s dependencies, because they need to be bumped together with Cilium. However, some k8s dependencies (k8s.io/kube-openapi) are not tagged with a version, but pinned by digest. This commit updates the Renovate config to ignore them too. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
lambdanis
added
area/ci
1 task
mtardy
approved these changes
Oct 5, 2023
|
We still have patch but those should hopefully work? At least it was the idea, it's annoying that some dependencies are not versioned together. |
Should work, although kube-openapi will be excluded from automatic updates and it seems that it's compatibility and versioning is being discussed (kubernetes/kube-openapi#421), so we'll see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renovate is configured to ignore minor and major updated of k8s dependencies, because they need to be bumped together with Cilium. However, some k8s dependencies (
k8s.io/kube-openapi) are not tagged with a version, but pinned by digest. Their updates are incompatible with other k8s deps, what's blocking updates of other Go dependencies, see #1372. This PR updates the Renovate config to ignore digest updates for k8s deps too.