Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tetragon.enableCiliumAPI option #1541

Merged
merged 1 commit into from
Oct 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
585 changes: 267 additions & 318 deletions cmd/tetragon/conf_test.go

Large diffs are not rendered by default.

2 changes: 0 additions & 2 deletions cmd/tetragon/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ const (

keyEnableK8sAPI = "enable-k8s-api"
keyK8sKubeConfigPath = "k8s-kubeconfig-path"
keyEnableCiliumAPI = "enable-cilium-api"
keyEnableProcessAncestors = "enable-process-ancestors"

keyMetricsServer = "metrics-server"
Expand Down Expand Up @@ -95,7 +94,6 @@ func readAndSetFlags() {

option.Config.EnableProcessCred = viper.GetBool(keyEnableProcessCred)
option.Config.EnableProcessNs = viper.GetBool(keyEnableProcessNs)
option.Config.EnableCilium = viper.GetBool(keyEnableCiliumAPI)
option.Config.EnableK8s = viper.GetBool(keyEnableK8sAPI)
option.Config.K8sKubeConfigPath = viper.GetString(keyK8sKubeConfigPath)

Expand Down
1 change: 0 additions & 1 deletion cmd/tetragon/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -700,7 +700,6 @@ func execute() error {
flags.String(keyLogFormat, "text", "Set log format")
flags.Bool(keyEnableK8sAPI, false, "Access Kubernetes API to associate Tetragon events with Kubernetes pods")
flags.String(keyK8sKubeConfigPath, "", "Absolute path of the kubernetes kubeconfig file")
flags.Bool(keyEnableCiliumAPI, false, "Access Cilium API to associate Tetragon events with Cilium endpoints and DNS cache")
flags.Bool(keyEnableProcessAncestors, true, "Include ancestors in process exec events")
flags.String(keyMetricsServer, "", "Metrics server address (e.g. ':2112'). Disabled by default")
flags.String(keyServerAddress, "localhost:54321", "gRPC server address (e.g. 'localhost:54321' or 'unix:///var/run/tetragon/tetragon.sock'")
Expand Down
1 change: 0 additions & 1 deletion docs/content/en/docs/reference/helm-chart.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ To use [the values available](#values), with `helm install` or `helm upgrade`, u
| tetragon.argsOverride | list | `[]` | |
| tetragon.btf | string | `""` | |
| tetragon.commandOverride | list | `[]` | |
| tetragon.enableCiliumAPI | bool | `false` | |
| tetragon.enableK8sAPI | bool | `true` | |
| tetragon.enableMsgHandlingLatency | bool | `false` | |
| tetragon.enablePolicyFilter | bool | `false` | |
Expand Down
1 change: 0 additions & 1 deletion docs/content/en/docs/reference/tetragon-configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ Flags:
--data-cache-size int Size of the data events cache (default 1024)
-d, --debug Enable debug messages. Equivalent to '--log-level=debug'
--disable-kprobe-multi Allow to disable kprobe multi interface
--enable-cilium-api Access Cilium API to associate Tetragon events with Cilium endpoints and DNS cache
--enable-export-aggregation Enable JSON export aggregation
--enable-k8s-api Access Kubernetes API to associate Tetragon events with Kubernetes pods
--enable-msg-handling-latency Enable metrics for message handling latency
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ hubble-enterprise:
image:
tag: v1.6.0
enabled: true
enableCiliumAPI: false
exportFilename: "fgs.log"
extraArgs:
"enable-process-cred": true
"enable-process-cred": true
1 change: 0 additions & 1 deletion examples/configuration/tetragon.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ config-dir:
tracing-policy:
debug: false
disable-kprobe-multi: false
enable-cilium-api: false
enable-export-aggregation: false
enable-k8s-api: false
enable-process-ancestors: true
Expand Down
1 change: 0 additions & 1 deletion install/kubernetes/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ Helm chart for Tetragon
| tetragon.argsOverride | list | `[]` | |
| tetragon.btf | string | `""` | |
| tetragon.commandOverride | list | `[]` | |
| tetragon.enableCiliumAPI | bool | `false` | |
| tetragon.enableK8sAPI | bool | `true` | |
| tetragon.enableMsgHandlingLatency | bool | `false` | |
| tetragon.enablePolicyFilter | bool | `false` | |
Expand Down
3 changes: 0 additions & 3 deletions install/kubernetes/templates/tetragon_configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ data:
{{- if .Values.tetragon.enableK8sAPI }}
enable-k8s-api: "true"
{{- end }}
{{- if .Values.tetragon.enableCiliumAPI }}
enable-cilium-api: "true"
{{- end }}
{{- if .Values.tetragon.prometheus.enabled }}
metrics-server: {{ .Values.tetragon.prometheus.address }}:{{ .Values.tetragon.prometheus.port }}
{{- else }}
Expand Down
2 changes: 0 additions & 2 deletions install/kubernetes/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,6 @@ tetragon:
{}
# Access Kubernetes API to associate Tetragon events with Kubernetes pods.
enableK8sAPI: true
# Access Cilium API to associate Tetragon events with Cilium endpoints and DNS cache.
enableCiliumAPI: false
# enableProcessCred enables Capabilities visibility in exec and kprobe events.
enableProcessCred: false
# enableProcessNs enables Namespaces visibility in exec and kprobe events.
Expand Down