Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renovate: add release-note/dependency label to PRs #1435

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

mtardy
Copy link
Member

@mtardy mtardy commented Sep 5, 2023

See #1384 (comment) and #1384 (comment).

Already created this label release-note/dependency This PR updates one or multiple dependencies (but renovate creates if needed anyway).

Should this be plural release-note/dependencies?

@mtardy mtardy added area/ci Related to CI release-note/ci This PR makes changes to the CI. labels Sep 5, 2023
@mtardy mtardy requested a review from a team as a code owner September 5, 2023 15:54
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥰 maybe keep the other labels too?

@mtardy
Copy link
Member Author

mtardy commented Sep 5, 2023

🥰 maybe keep the other labels too?

are they useful? A dep bump is not really an enhancement and I don't know if we use this release-blocker thing, it seems we mostly ignore it :D! what do you think?

@michi-covalent
Copy link
Contributor

i don't know about "kind/enhancement" label, but we do check "release-blocker" label during the release https://github.com/cilium/tetragon/blame/main/.github/ISSUE_TEMPLATE/release_template.md#L11 to make sure dependencies are kept up to date 🤖

See #1384 (comment) and
#1384 (comment).

Signed-off-by: Mahé <mahe.tardy@gmail.com>
@mtardy mtardy force-pushed the pr/mtardy/renovate-release-note branch from edc487f to 33a96c4 Compare September 5, 2023 16:20
@mtardy mtardy merged commit d7f09ea into main Sep 6, 2023
@mtardy mtardy deleted the pr/mtardy/renovate-release-note branch September 6, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Related to CI release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants