Remove tetragon.enableCiliumAPI configuration option #1420
Conversation
michi-covalent
force-pushed
the
pr/michi/disappear
branch
3 times, most recently
from
9960c5b to
e4f1050
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
michi-covalent
force-pushed
the
pr/michi/disappear
branch
from
e4f1050 to
69698fb
Compare
michi-covalent
changed the title
michi-covalent
force-pushed
the
pr/michi/disappear
branch
from
69698fb to
c8faaf7
Compare
Pod.Labels field got deprecated in v0.11 [^1], so we can stop setting the field in main branch. This means that Tetragon no longer depends on the Cilium state, so we don't have to synchronize it anymore. This patch removes tetragon.enableCiliumAPI Helm value and deletes packages related to Cilium state synchronization. [^1]: #1363 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/disappear
branch
from
c8faaf7 to
ed4ad61
Compare
| @@ -94,7 +94,6 @@ func readAndSetFlags() { | |||
|
|
|||
| option.Config.EnableProcessCred = viper.GetBool(keyEnableProcessCred) | |||
| option.Config.EnableProcessNs = viper.GetBool(keyEnableProcessNs) | |||
| option.Config.EnableCilium = viper.GetBool(keyEnableCiliumAPI) | |||
There was a problem hiding this comment.
Would it make sense to keep the option and only fail it is set to true? I think this would enable us to run the :latest image with the old helm charts that define this option. We can remove it once we have released the next versin.
|
Hey, should we merge that (once it's rebased)? It's still in draft for now. |
mtardy
added
the
needs-rebase
|
Should we close this one now that #1541 was merged? maybe it was missing the:
|
|
yeah this one is a much bigger change since it actually deletes |
Pod.Labels field got deprecated in v0.11 1, so we can stop setting the
field in main branch. This means that Tetragon no longer depends on
the Cilium state, so we don't have to synchronize it anymore. This patch
removes tetragon.enableCiliumAPI Helm value and deletes packages related
to Cilium state synchronization.
Signed-off-by: Michi Mutsuzaki michi@isovalent.com
Footnotes
https://github.com/cilium/tetragon/pull/1363 ↩