Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tetragon-operator-config ConfigMap #1337

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

michi-covalent
Copy link
Contributor

@michi-covalent michi-covalent commented Aug 8, 2023

  • Add tetragon-operator-config ConfigMap.
  • Add tetragonOperator.skipCRDCreation Helm value.
  • Mount the ConfigMap to /etc/tetragon/operator.conf.d/ and load the
    config from the directory.
  • Log the config at the startup.

Ref: #794

sample log output:

level=info msg="Loaded config from directory" config-dir=/etc/tetragon/operator.conf.d/ subsys=tetragon-operator
level=info msg="Starting Tetragon Operator" config="&{SkipCRDCreation:false KubeCfgPath: ConfigDir:/etc/tetragon/operator.conf.d/}" subsys=tetragon-operator version=v0.10.0-145-g8b2a7e8f
level=info msg="CRD (CustomResourceDefinition) is installed and up-to-date" name=TracingPolicy/v1alpha1 subsys=k8s
level=info msg="CRD (CustomResourceDefinition) is installed and up-to-date" name=TracingPolicyNamespaced/v1alpha1 subsys=k8s
level=info msg="Initialization complete" subsys=tetragon-operator

@netlify
Copy link

netlify bot commented Aug 8, 2023

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit a4299ab
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/64d2c36648825a0008a2a874
😎 Deploy Preview https://deploy-preview-1337--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@michi-covalent michi-covalent force-pushed the pr/michi/struggle branch 3 times, most recently from a78d679 to 8b2a7e8 Compare August 8, 2023 23:15
- Add tetragon-operator-config ConfigMap.
- Add tetragonOperator.skipCRDCreation Helm value.
- Mount the ConfigMap to /etc/tetragon/operator.conf.d/ and load the
  config from the directory.
- Log the config at the startup.

Ref: #794

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent changed the title Pr/michi/struggle Add tetragon-operator-config ConfigMap Aug 8, 2023
@michi-covalent michi-covalent marked this pull request as ready for review August 8, 2023 23:46
@michi-covalent michi-covalent requested review from mtardy and a team as code owners August 8, 2023 23:46
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!!

This is out of the scope of this PR and maybe that's already the project but I guess it would make sense that the tetragon-operator is not an init-container per daemon running in k8s but just a deployment with only 1 instance that is long-running right? I guess this is completely what you are trying to do atm.

@michi-covalent michi-covalent merged commit e03e50a into main Aug 9, 2023
@michi-covalent michi-covalent deleted the pr/michi/struggle branch August 9, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants