Cleanup: add no-unused-vars and imports eslint rules and fix the codebase #790
+4,161
−5,050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannikmesserli
requested review from
kimstacy
and removed request for
a team
yandzee
reviewed
Mar 1, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
yannikmesserli
force-pushed
the
pr/yannik/no-used-vars
branch
from
09c1771 to
fd2b59c
Compare
yannikmesserli
requested review from
geakstr and
yandzee
and removed request for
kimstacy and
yandzee
Signed-off-by: Yannik Messerli <yannik.messerli@gmail.com>
yannikmesserli
force-pushed
the
pr/yannik/no-used-vars
branch
from
fd2b59c to
fc2ad0c
Compare
geakstr
approved these changes
Jan 20, 2025
yannikmesserli
dismissed
yandzee’s stale review
Renat does not work on the project anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No issue.
Description
This PR adds the no-unused-vars and imports eslint rules. Then, I ran
eslint --fixand finally fixed the remaining issue that couldn't be automatically fixedChanges
unused-importswhich is better than the default rules.eslintrc.jswith["error", { "ignoreRestSiblings": true }]Screenshots
n/a
Unit tests
They should still all pass
Functional tests
It's probably worth testing quickly the entire app, to see that nothing have been broken.