Fix: Hide the download button if it is an empty file infiniflow#3762

cike8899 · Dec 4, 2024 · f38e408 · f38e408
1 parent cf37e2e
commit f38e408
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 21 deletions.
diff --git a/web/src/constants/knowledge.ts b/web/src/constants/knowledge.ts
@@ -57,3 +57,8 @@ export enum KnowledgeSearchParams {
   DocumentId = 'doc_id',
   KnowledgeId = 'id',
 }
+
+export enum DocumentType {
+  Virtual = 'virtual',
+  Visual = 'visual',
+}
diff --git a/web/src/pages/add-knowledge/components/knowledge-file/parsing-action-cell/index.tsx b/web/src/pages/add-knowledge/components/knowledge-file/parsing-action-cell/index.tsx
@@ -11,6 +11,7 @@ import {
 import { Button, Dropdown, MenuProps, Space, Tooltip } from 'antd';
 import { isParserRunning } from '../utils';
 
+import { DocumentType } from '../constant';
 import styles from './index.less';
 
 interface IProps {
@@ -31,6 +32,7 @@ const ParsingActionCell = ({
   const { t } = useTranslate('knowledgeDetails');
   const { removeDocument } = useRemoveNextDocument();
   const showDeleteConfirm = useShowDeleteConfirm();
+  const isVirtualDocument = record.type === DocumentType.Virtual;
 
   const onRmDocument = () => {
     if (!isRunning) {
@@ -73,15 +75,17 @@ const ParsingActionCell = ({
 
   return (
     <Space size={0}>
-      <Dropdown
-        menu={{ items: chunkItems }}
-        trigger={['click']}
-        disabled={isRunning}
-      >
-        <Button type="text" className={styles.iconButton}>
-          <ToolOutlined size={20} />
-        </Button>
-      </Dropdown>
+      {isVirtualDocument || (
+        <Dropdown
+          menu={{ items: chunkItems }}
+          trigger={['click']}
+          disabled={isRunning}
+        >
+          <Button type="text" className={styles.iconButton}>
+            <ToolOutlined size={20} />
+          </Button>
+        </Dropdown>
+      )}
       <Tooltip title={t('rename', { keyPrefix: 'common' })}>
         <Button
           type="text"
@@ -102,16 +106,18 @@ const ParsingActionCell = ({
           <DeleteOutlined size={20} />
         </Button>
       </Tooltip>
-      <Tooltip title={t('download', { keyPrefix: 'common' })}>
-        <Button
-          type="text"
-          disabled={isRunning}
-          onClick={onDownloadDocument}
-          className={styles.iconButton}
-        >
-          <DownloadOutlined size={20} />
-        </Button>
-      </Tooltip>
+      {isVirtualDocument || (
+        <Tooltip title={t('download', { keyPrefix: 'common' })}>
+          <Button
+            type="text"
+            disabled={isRunning}
+            onClick={onDownloadDocument}
+            className={styles.iconButton}
+          >
+            <DownloadOutlined size={20} />
+          </Button>
+        </Tooltip>
+      )}
     </Space>
   );
 };

diff --git a/web/src/pages/add-knowledge/components/knowledge-file/parsing-status-cell/index.tsx b/web/src/pages/add-knowledge/components/knowledge-file/parsing-status-cell/index.tsx
@@ -7,7 +7,7 @@ import { Badge, DescriptionsProps, Flex, Popover, Space, Tag } from 'antd';
 import classNames from 'classnames';
 import { useTranslation } from 'react-i18next';
 import reactStringReplace from 'react-string-replace';
-import { RunningStatus, RunningStatusMap } from '../constant';
+import { DocumentType, RunningStatus, RunningStatusMap } from '../constant';
 import { useHandleRunDocumentByIds } from '../hooks';
 import { isParserRunning } from '../utils';
 import styles from './index.less';
@@ -96,7 +96,7 @@ export const ParsingStatusCell = ({ record }: IProps) => {
     handleRunDocumentByIds(record.id, isRunning);
   };
 
-  return (
+  return record.type === DocumentType.Virtual ? null : (
     <Flex justify={'space-between'} align="center">
       <Popover content={<PopoverContent record={record}></PopoverContent>}>
         <Tag color={runningStatus.color}>