Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sonar 6.7+ support #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feature/sonar 6.7+ support #1

wants to merge 3 commits into from

Conversation

brianbaker
Copy link

The current version of the plugin uses the deprecated sonar.branch parameter. This PR updates that param to use sonar.branch.name. See https://docs.sonarqube.org/display/PLUG/Branch+Plugin

@brianbaker
Copy link
Author

I had to remove the sonar.project.branch param entirely as Sonar requires that the first scan of a project not supply sonar.branch.name. After that first scan, sonar.branch.name can be supplied. My recommendation is to remove the parameter entirely. Its easy enough to supply it in the additional args. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brianbaker