Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative order of local declarations. #110

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Fix relative order of local declarations. #110

merged 1 commit into from
Feb 12, 2019

Conversation

joewing
Copy link
Contributor

@joewing joewing commented Jan 29, 2019

Now that locals can have initial values (see #109), their relative order matters. For top-level locals, the order was being preserved, but the order was being reversed for locals declared in an inner scope such as a loop. This fixes the order and adds a test.

Copy link

@johndavidhahn johndavidhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joewing joewing merged commit 34bd584 into master Feb 12, 2019
@joewing joewing deleted the fix-locals branch February 12, 2019 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants