Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass destinationElement to basic-dropdown #1863

Conversation

andreyfel
Copy link
Contributor

ember-basic-dropdown accepts destinationElement argument and power-select should to support it as well.

ember-basic-dropdown accepts `destinationElement` argument and
power-select should to support it as well.
Copy link
Collaborator

@mkszepp mkszepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM

@mkszepp mkszepp merged commit 77e1fce into cibernox:master Dec 4, 2024
20 checks passed
@andreyfel andreyfel deleted the pass-destination-element-to-basic-dropdown branch December 5, 2024 08:59
@andreyfel
Copy link
Contributor Author

@mkszepp thanks for merging! Could you please cut a new release?

@mkszepp
Copy link
Collaborator

mkszepp commented Dec 5, 2024

@andreyfel released in v8.5.0

@andreyfel
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants