Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ember-inflector in docs to fix docs page (cause ember-data bug) #1841

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

mkszepp
Copy link
Collaborator

@mkszepp mkszepp commented Jun 21, 2024

The current ember-data version brakes docs page. We don't use any ember-inflector but ember-data brakes production build when there is not installed

This PR fix for the moment our docs build without downgrading ember-data (see emberjs/data#9501)

The error occurs only in production build, ember test or also with ember s there works fine

@mkszepp mkszepp changed the title Add ember-inflector in docs cause ember-data bug Add ember-inflector in docs to fix docs page (cause ember-data bug) Jun 21, 2024
@mkszepp mkszepp merged commit bfe272b into master Jun 21, 2024
18 checks passed
@mkszepp mkszepp deleted the fix-docs-cause-ember-data-bug branch June 21, 2024 10:47
@runspired
Copy link

for any future wanderers, the bug here is that ember-inflector is installed as a dependency by ember-cli-mirage, but not included in production builds if ember-cli-mirage is the only thing that brings it as a dependency, which then breaks @embroider/macros.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants