Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update invalid type imports #1589

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

HeroicEric
Copy link
Contributor

@HeroicEric HeroicEric commented Jul 25, 2023

Copied from #1577

For consumers that end up importing this file, the type declarations don't include /addon

/addon ends up working during development time, because the original source is in TS -- but it ends up not being the same as the emitted declarations.

This was also previously fixed in #1560 but it seems maybe that was accidentally removed in 617ccee ?

Copied from cibernox#1577

For consumers that end up importing this file, the type declarations
don't include `/addon`

`/addon` ends up working during development time, because the original
source is in TS -- but it ends up not being the same as the emitted
declarations.
@RobbieTheWagner RobbieTheWagner merged commit 52e9e07 into cibernox:master Jul 25, 2023
@HeroicEric HeroicEric deleted the fix-types branch July 25, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants