Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support local mount points #7

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

jrhuerta
Copy link
Contributor

Hi there! Thank you for reviewing these proposed changes.

Support for file:// schema for local images: This update enables mounting images directly from local paths when using docker. It’s particularly helpful for scenarios where the image is already available on the host machine, allowing for easier access and flexibility.

Automated execution of convert.py at container startup: This change automates the process of running convert.py whenever the container starts, simplifying workflows where the model is mounted as a Docker volume. I found this especially useful when training custom models.

I also took the opportunity to update the README to reflect these changes, but please feel free to adjust as needed.

Thank you once again,
Joaquin

jrhuerta and others added 2 commits November 18, 2024 16:00
@chvvkumar
Copy link
Owner

chvvkumar commented Nov 19, 2024

Thank you! I will merge it to dev. You can also test the container once it's built by pulling the dev tag from docker hub.

docker pull chvvkumar/simpleclouddetect:dev

@chvvkumar chvvkumar merged commit c9824c0 into chvvkumar:dev Nov 19, 2024
@chvvkumar chvvkumar mentioned this pull request Nov 20, 2024
Merged
@chvvkumar
Copy link
Owner

@jrhuerta I am going to push another update to the main branch. This update takes out the model file from the container and allows you to mount the file as a bind mount so that you can change the model file at will without needing to rebuild the image. FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants