Update how task results are decoded & how the upload request for download is done
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imes and since we control both the server and client, we can set higher standards
…s the result. This makes sure any weirdly encoded files won't cause cat, etc. that directly return file bytes to fail.
…fixes an issue where if the receiving service, such as lambda, checks content strictly, the request is not dropped
…y external ip changes
…eplace `'` with `\"` when parsing on the nim side since we are in json
|
This is great! Thank you so much for getting rid of some of the technical debt 😅. Great fixes, and wonderful implementation! 💯 |
chvancooten
added a commit
that referenced
this pull request
Mar 7, 2024
…arsing and unclear naming, symbol renaming spree, various fixes and refactorings
This was referenced Mar 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues, increases the supported certificate version, adds more verbose messaging around errors, and also logs any external IP changes:
catis run on a non-utf8 encoded file, the server won't be able to parse the task results. The approach in this PR uses fallback encodings to see if we can decode the result with any other encodings, and if we can, re-encodes everything with utf8.For my use cases,
shift_jisandeuc-jpare enough. The exact order and number of fallback encodings are up for debate and this could be a config option, so users who don't need the flexibility can disable it.downloadcommand gzips and encrypts the target file before uploading it to the server. Since encryption happens after compression, the request content is base64 instead of gzipped bytes. If we have theContent-Encoding: gzipheader when the content is base64, services such as AWS Lambda where a request is fully parsed before getting passed to the backend, the request will fail with 415 Unsupported Media Type. Removing theContent-Encoding: gzipheader fixes this issue.An alternative would be reversing the compress/encrypt order, but compressing an encrypted blob would yield bigger file sizes.
The current server allows https connections from SSLv3 upwards. Rust clients can complain about this, and since we control both server and client, there's no need to support such old methods. This PR updates
ssl_versionto TLS 1.2.Currently, it's difficult to debug why a request was rejected or where an exception occurred. I have increased the verbosity of
all_exception_handlerwith adump_debug_info_for_exceptionmethod and updated hownotifyBadRequestworks to give better guidance on why a request might have been rejected.Logging changes in external ip address would allow better accounting, since as it is now, we'd only have access to the latest external ip.