-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error with unicode #23
Comments
Hi @sl4cky, thanks for the report! That is indeed an edge case that I didn't test :) |
Did some testing. The issue is with the winUtils.nim file and the getIntIp function, don't know exactly what the issue is with that function but I know the issue is there. whoami does not present the unicode but it doesn't make the agent fail to connect back. the issue makes the agent fail to connect back after the register request |
Hi @sl4cky! Thanks for looking into it. I found some time to troubleshoot the issue. It looks like there was in issue in the |
Hi, yes will do it and let you know. Thanks 🙏 |
Hi So I checked this, the whoami is okay but there is still an issue if the computername is with unicode, for this a change need to be done in the function proc getHost*() : string = of winutils. the winapi GetComputerNameW can be used for this I guess. |
Hi @sl4cky, thanks again for reporting this and sorry for the delay. I have updated the |
OS and version:
ubuntu 22.04
Python version:
Python 3.10.1
Nim version:
Nim Compiler Version 1.6.12 [Linux: amd64]
Using Docker: Yes/No
No
Issue Description
When a target computer use unicode in their username / computername like Russian or Chineese or else it doesn't manage to communicate properly with the server.
following is the error :
An unexpected exception occurred when handling command: TypeError('unsupported format string passed to NoneType.format')
Screenshots
The text was updated successfully, but these errors were encountered: