Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#14] Add parallelism level and dependency sum time to profile summary #18

Merged
merged 2 commits into from
Aug 5, 2022
Merged

[#14] Add parallelism level and dependency sum time to profile summary #18

merged 2 commits into from
Aug 5, 2022

Conversation

bradrn
Copy link
Contributor

@bradrn bradrn commented Aug 5, 2022

Closes #14.

@bradrn bradrn requested a review from chshersh as a code owner August 5, 2022 02:45
@chshersh chshersh added the enhancement New feature or request label Aug 5, 2022
@chshersh chshersh changed the title Add parallelism level and dependency sum time to profile summary [#14] Add parallelism level and dependency sum time to profile summary Aug 5, 2022
chshersh
chshersh requested changes Aug 5, 2022
View reviewed changes
Copy link
Owner

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool implementation! 👏🏻 Straightforward and simple 🙂

I have only one minor suggestion for the code. The rest looks great 👍🏻

I can already check this nice summary on my projects 😎

image

src/DrCabal/Profile/Stacked.hs Outdated Show resolved Hide resolved
src/DrCabal/Profile/Format.hs Show resolved Hide resolved
@bradrn @chshersh
Simplify definition of totalAllPhases
38f9c2b 
This also helps with strictness.

Co-authored-by: Dmitrii Kovanikov <kovanikov@gmail.com>
chshersh
chshersh approved these changes Aug 5, 2022
View reviewed changes
Copy link
Owner

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍🏻

@chshersh chshersh merged commit bb59471 into chshersh:main Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chshersh chshersh chshersh approved these changes

Assignees

@bradrn bradrn

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 'Parallelism level' to profile summary
2 participants
@bradrn @chshersh