Add std::convert::From conversion between different DateTime offsets #271

mqudsi · 2018-08-12T03:14:43Z

Adds conversion to/from Utc, Local, and FixedOffset. Originally planned
to go through NaiveDateTime, but it seems that is not necessary?

Ref #263

Adds conversion to/from Utc, Local, and FixedOffset. Originally planned to go through NaiveDateTime, but it seems that is not necessary?

quodlibetor

This looks reasonable, other than adding some doccos and that you need to import some items into scope.

src/datetime.rs

Documentation added to both `impl`s and functions so that they are visible to both users perusing the online documentation and in autocomplete/intellisense engines.

As discussed in chronotope#263. Note that this breaks existing code that did not explicitly specify the offset in calls to `DateTime::parse_from_*`, as they are now ambiguous. Relies on chronotope#271 for conversion back into `DateTime<Utc>` from `DateTime<FixedOffset>` as the latter is used under the hood.

mqudsi · 2018-09-06T00:17:56Z

Should be ready for review, @quodlibetor

mqudsi · 2018-10-03T14:22:02Z

@quodlibetor did you get a chance to review this?

mqudsi · 2018-12-06T03:19:30Z

gentle bump

theduke · 2019-01-25T01:32:20Z

A gentle bump from me, those conversions would be very useful.

quodlibetor · 2019-01-25T21:37:45Z

Sorry this fell of my radar!

It looks like the test failures are just a simple use offset::Local away @mqudsi if you would like to get it passing, and add yourself to the changelog I will be happy to merge.

Thanks!

ErichDonGubler · 2019-04-08T03:48:33Z

@mqudsi, is there anything left to do on this besides just fixing the test failures? I'm anxious to be able to use this. :P

mqudsi · 2019-04-08T15:00:59Z

Those aren't CI test failures, they're actual build errors. The code has always compiled for me (my only rule is never commit something that doesn't build). Perhaps it has to do with the rustc version the build pipeline is (was?) using. On my end, it builds and passes all the tests:


test result: ok. 212 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

mqudsi@ZBOOK /m/c/U/m/r/chrono> git branch
  master
* offset_convert
  utc_from_str
mqudsi@ZBOOK /m/c/U/m/r/chrono> git rev-parse HEAD
973c603d7af0a0573a1fc43c430cd93f243a1eeb

Actually, it seems that use offset::Local was gated on the clock feature. Rather than ungating the use declaration, I presume the right thing to do here would be to similarly gate the conversion functions relying on clock functionality.

quodlibetor · 2019-04-08T15:08:29Z

That does make sense, if we can get this merged that would be great!

mqudsi · 2019-04-08T15:09:39Z

Updated w/ the changes requested. Now builds for me locally with --no-default-features.

mqudsi · 2019-04-08T15:10:55Z

Thanks, @quodlibetor. btw my changelog.md updates presume this is going into a 0.4.6 release. Feel free to change.

As discussed in chronotope#263. Note that this breaks existing code that did not explicitly specify the offset in calls to `DateTime::parse_from_*`, as they are now ambiguous. Relies on chronotope#271 for conversion back into `DateTime<Utc>` from `DateTime<FixedOffset>` as the latter is used under the hood.

quodlibetor · 2019-04-08T16:37:45Z

thanks @mqudsi for this change and thanks @ErichDonGubler for the ping pushing it over the finish line!

As discussed in chronotope#263. Note that this breaks existing code that did not explicitly specify the offset in calls to `DateTime::parse_from_*`, as they are now ambiguous. Relies on chronotope#271 for conversion back into `DateTime<Utc>` from `DateTime<FixedOffset>` as the latter is used under the hood.

As discussed in #263. Note that this breaks existing code that did not explicitly specify the offset in calls to `DateTime::parse_from_*`, as they are now ambiguous. Relies on #271 for conversion back into `DateTime<Utc>` from `DateTime<FixedOffset>` as the latter is used under the hood.

- Creates a global Error enum - Breaks backwards compatiblility mainly because of promoting fallable functions (chronotope#263) - Some tests still fall - Not all doctests are fixed - to_naive_datetime_with_offset function is broken and needs fixing - serde related stuff is not checked properly This is a rebase of chronotope#817 onto the 0.5 main branch. Main differences: - Unify three different error structs - Removed ErrorKind - Adapted a lot of unit tests - Removed some commits from presumably unrelated branches (chronotope#829) or mainlined commits (chronotope#271) Co-authored-by: John-John Tedro <udoprog@tedro.se>

More tests for combinations of `DateTime::into`. Follow-up to Pull Request chronotope#271.

More tests for combinations of `DateTime::into`. Follow-up to Pull Request chronotope#271. Issue chronotope#263

More tests for combinations of `DateTime::into`. Follow-up to Pull Request chronotope#271.

Add initial implementation of std::convert::From for DateTime offsets

855d5f2

Adds conversion to/from Utc, Local, and FixedOffset. Originally planned to go through NaiveDateTime, but it seems that is not necessary?

mqudsi mentioned this pull request Aug 12, 2018

Improvements to parsing into Utc, converting from other timezones to Utc #263

Closed

quodlibetor requested changes Aug 12, 2018

View reviewed changes

src/datetime.rs Show resolved Hide resolved

mqudsi added 2 commits September 5, 2018 18:25

Add doc ccomments for conversions between DateTime flavors

7f4d0da

Documentation added to both `impl`s and functions so that they are visible to both users perusing the online documentation and in autocomplete/intellisense engines.

Add basic conversion test

973c603

mqudsi force-pushed the offset_convert branch from 46165c8 to 973c603 Compare September 6, 2018 00:08

mqudsi mentioned this pull request Sep 6, 2018

Add parse_from_* to DateTime #278

Closed

mqudsi changed the title ~~[WIP] Add initial implementation of std::convert::From for DateTime offsets~~ Add initial implementation of std::convert::From for DateTime offsets Oct 3, 2018

Predicate Local conversion fns on clock feature

ad6872c

Update Changelog to mention std::convert::From conversions

43447e5

mqudsi force-pushed the offset_convert branch from 86a7f1e to 43447e5 Compare April 8, 2019 15:15

mqudsi changed the title ~~Add initial implementation of std::convert::From for DateTime offsets~~ Add std::convert::From conversion between different DateTime offsets Apr 8, 2019

mqudsi mentioned this pull request Apr 8, 2019

Added Offset support to Local #305

Closed

quodlibetor approved these changes Apr 8, 2019

View reviewed changes

quodlibetor merged commit bcdc66a into chronotope:master Apr 8, 2019

quodlibetor mentioned this pull request Dec 23, 2019

Add From impls for DateTime #67

Closed

mqudsi mentioned this pull request Aug 31, 2022

Add parse_from_xxx to DateTime<Utc> #806

Merged

Zomtir mentioned this pull request Mar 22, 2023

Fallable constructors for less panics (#815) #996

Closed

This was referenced Apr 27, 2023

Use correct offset in conversion from Local to FixedOffset #1041

Merged

No way to convert Datetime<FixedOffset> to Datetime<Local> #193

Closed

jtmoon79 added a commit to jtmoon79/chrono that referenced this pull request May 28, 2023

Add more DateTime.into tests

c8614e4

More tests for combinations of `DateTime::into`. Follow-up to Pull Request chronotope#271.

jtmoon79 mentioned this pull request May 28, 2023

Add more DateTime.into tests (branch 0.4.x) #1088

Closed

jtmoon79 added a commit to jtmoon79/chrono that referenced this pull request May 28, 2023

Add more DateTime.into tests

17bbef7

More tests for combinations of `DateTime::into`. Follow-up to Pull Request chronotope#271.

jtmoon79 added a commit to jtmoon79/chrono that referenced this pull request May 28, 2023

Add more DateTime.into tests

7b4da00

More tests for combinations of `DateTime::into`. Follow-up to Pull Request chronotope#271. Issue chronotope#263

jtmoon79 added a commit to jtmoon79/chrono that referenced this pull request May 28, 2023

Add more DateTime.into tests

0127fd7

More tests for combinations of `DateTime::into`. Follow-up to Pull Request chronotope#271.

pitdicker mentioned this pull request Jul 21, 2023

From/Into implemenation for DateTime<FixedOffset/Utc> conversion? #831

Closed

jtmoon79 added a commit to jtmoon79/chrono that referenced this pull request Sep 21, 2023

Add more DateTime.into tests

af4d8a4

More tests for combinations of `DateTime::into`. Follow-up to Pull Request chronotope#271.

jtmoon79 added a commit to jtmoon79/chrono that referenced this pull request Sep 21, 2023

Add more DateTime.into tests

e282568

More tests for combinations of `DateTime::into`. Follow-up to Pull Request chronotope#271.

jtmoon79 added a commit to jtmoon79/chrono that referenced this pull request Sep 21, 2023

Add more DateTime.into tests

6df882c

More tests for combinations of `DateTime::into`. Follow-up to Pull Request chronotope#271.

jtmoon79 added a commit to jtmoon79/chrono that referenced this pull request Sep 21, 2023

Add more DateTime.into tests

48f88fc

More tests for combinations of `DateTime::into`. Follow-up to Pull Request chronotope#271.

jtmoon79 added a commit to jtmoon79/chrono that referenced this pull request Sep 25, 2023

Add more DateTime.into tests

e813233

More tests for combinations of `DateTime::into`. Follow-up to Pull Request chronotope#271.

jtmoon79 added a commit to jtmoon79/chrono that referenced this pull request Sep 25, 2023

Add more DateTime.into tests

546dd9d

More tests for combinations of `DateTime::into`. Follow-up to Pull Request chronotope#271.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add std::convert::From conversion between different DateTime offsets #271

Add std::convert::From conversion between different DateTime offsets #271

mqudsi commented Aug 12, 2018

quodlibetor left a comment

mqudsi commented Sep 6, 2018

mqudsi commented Oct 3, 2018

mqudsi commented Dec 6, 2018

theduke commented Jan 25, 2019

quodlibetor commented Jan 25, 2019

ErichDonGubler commented Apr 8, 2019 •

edited

Loading

mqudsi commented Apr 8, 2019

quodlibetor commented Apr 8, 2019

mqudsi commented Apr 8, 2019

mqudsi commented Apr 8, 2019

quodlibetor commented Apr 8, 2019

Add std::convert::From conversion between different DateTime offsets #271

Add std::convert::From conversion between different DateTime offsets #271

Conversation

mqudsi commented Aug 12, 2018

quodlibetor left a comment

Choose a reason for hiding this comment

mqudsi commented Sep 6, 2018

mqudsi commented Oct 3, 2018

mqudsi commented Dec 6, 2018

theduke commented Jan 25, 2019

quodlibetor commented Jan 25, 2019

ErichDonGubler commented Apr 8, 2019 • edited Loading

mqudsi commented Apr 8, 2019

quodlibetor commented Apr 8, 2019

mqudsi commented Apr 8, 2019

mqudsi commented Apr 8, 2019

quodlibetor commented Apr 8, 2019

ErichDonGubler commented Apr 8, 2019 •

edited

Loading