This repository has been archived by the owner on Jan 15, 2023. It is now read-only.
Non static IoC container. (Preparation of work for Custom IoC containers ) #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whats the point of this pull request?
Currently Chromely uses dependency injection through static IoC container. This is bad. In fact, static IoC container is not dependency injection. It is Service Location, which is anti-pattern.
This pull request tries to fix this, at least on some parts. Sure, there are many points, where it can be done better (For example in many places IChromelyContainer is still injected or used via ChromelyConfiguration), but this is just start.
I'm looking forward to hear from maintainers of this repository suggestions, how can I improve this pull request. Thanks.
What have been done:
Next steps.