Allow commit hash to not be known when finding merge queue PR number #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianbruntonsagecom
changed the title
JonathanKolnik
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
That makes a lot of sense, thank you @adrianbruntonsagecom!
JonathanKolnik
added
release
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amends change made to v10.0.0 with PR #863 to allow GitHub merge queue branches to be matched when they are using the "squash and merge" merge method. Currently, the branch name is expected to contain a known commit hash, but given commits can be squashed, the commit hash may not be known.
This change therefore loosens the branch name regex match to only check for a known pattern rather than assuming to find a specific commit hash within it. Once it finds the PR number, it can then find the original branch name as it is doing currently.
Fixes #871