Retrieve sentinelUrls from uploadBuild and wait for all of them before finishing upload task
#878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uploadbuild-mutation' into ghengeveld/ap-3971-cli-pass-content-hashes-to-uploadbuild-mutation
…o-uploadbuild-mutation
…e finishing upload task
ghengeveld
added
release
ghengeveld
changed the base branch from
ghengeveld/ap-3971-cli-pass-content-hashes-to-uploadbuild-mutation
to
ghengeveld/ap-4034-batch-file-upload-requests-to-handle-thousands-of-files
…-thousands-of-files' into ghengeveld/ap-3912-index-update-cli-to-wait-for-copy-job-using-sentinel-file
ghengeveld
added
skip-release
ghengeveld
merged commit bd5e1e7
into
ghengeveld/ap-4034-batch-file-upload-requests-to-handle-thousands-of-files
23 of 25 checks passed
ghengeveld
deleted the
ghengeveld/ap-3912-index-update-cli-to-wait-for-copy-job-using-sentinel-file
branch
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on https://github.com/chromaui/chromatic/pull/8075
Stacks on #875
This ensures the CLI waits for both file copying and zip unpacking before completing the upload task.
Canary:
chromatic@10.1.1--canary.c99cfb4.0📦 Published PR as canary version:
10.3.1--canary.878.7542886160.0✨ Test out this PR locally via:
npm install chromatic@10.3.1--canary.878.7542886160.0 # or yarn add chromatic@10.3.1--canary.878.7542886160.0