-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make @storybook/csf-tools
a peer dependency
#874
Conversation
We should probably try to optimize this inside @valentinpalkovic and i have discussed rewriting in SWC and I'm not sure whether that would help or hurt the install size. |
@storybook/csf-tools
a peer dependency
@ghengeveld we should decide whether we want to make this change. Upside: our package is ~1.15MB smaller (main chunk I made a change to only import async so that the above issue will only affect such package manager users if they are on SB6 (where we actually use the code). We'll also need to figure out how to document this. |
|
After some consideration we decided not to do this an instead reduce the size of |
Externalize
@storybook/csf-tools
which is a large dependency which will have been by installed by the user already (see this conversation: https://chromaticqa.slack.com/archives/CMMBWSJ1W/p1702342681865589).We only use that package for metadata extraction in SB6 so we should verify this doesn't break that.
📦 Published PR as canary version:
11.0.0--canary.874.7204664733.0
✨ Test out this PR locally via:
npm install chromatic@11.0.0--canary.874.7204664733.0 # or yarn add chromatic@11.0.0--canary.874.7204664733.0