Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/10minute timeout action #278

Merged
merged 9 commits into from
Feb 10, 2021
Merged

Fix/10minute timeout action #278

merged 9 commits into from
Feb 10, 2021

Conversation

ndelangen
Copy link
Member

issue: #273

@ndelangen ndelangen force-pushed the fix/10minute-timeout-action branch from b655a1c to ca9e9fe Compare February 10, 2021 14:11
@ndelangen ndelangen self-assigned this Feb 10, 2021
@ndelangen ndelangen added bug Classification: Something isn't working URGENT labels Feb 10, 2021
ndelangen
ndelangen commented Feb 10, 2021
View reviewed changes
action/main.ts
setFailed('non-zero exit code');
}

process.exit(output.code);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here's the fix

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inspired from:

chromatic-cli/bin/main.js

Lines 33 to 36 in 906f442

await runAll(ctx);
log.info('');
process.exit(ctx.exitCode);

@ndelangen
Copy link
Member Author

Looks like it's running in 2m consistency..

@ndelangen ndelangen requested a review from ghengeveld February 10, 2021 14:40
ghengeveld
ghengeveld reviewed Feb 10, 2021
View reviewed changes
action/main.ts Outdated Show resolved Hide resolved
ghengeveld
ghengeveld reviewed Feb 10, 2021
View reviewed changes
action/main.ts Outdated Show resolved Hide resolved
ghengeveld
ghengeveld approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@ghengeveld ghengeveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndelangen ndelangen merged commit d64c566 into next Feb 10, 2021
@ndelangen ndelangen deleted the fix/10minute-timeout-action branch February 10, 2021 14:49
This was referenced Mar 11, 2021
Merged
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghengeveld ghengeveld ghengeveld approved these changes

Assignees

@ndelangen ndelangen

Labels
bug Classification: Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndelangen @ghengeveld