Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix directory flags for trace command. #1148

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

jmhobbs
Copy link
Contributor

@jmhobbs jmhobbs commented Jan 30, 2025

The trace command was not putting the flag values where they belong, leading to a lot of confusion when tracing projects in sub-directories. The main Chromatic command works as intended. H/T @codykaup for finding this.

📦 Published PR as canary version: 11.25.3--canary.1148.13066235606.0

✨ Test out this PR locally via:

npm install chromatic@11.25.3--canary.1148.13066235606.0
# or 
yarn add chromatic@11.25.3--canary.1148.13066235606.0

@jmhobbs jmhobbs requested a review from a team January 30, 2025 21:54
@jmhobbs jmhobbs self-assigned this Jan 30, 2025
Copy link
Contributor

📦 Package Size: 5448 KB

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.00%. Comparing base (9047fb7) to head (0223abc).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
bin-src/trace.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1148      +/-   ##
==========================================
- Coverage   70.04%   70.00%   -0.04%     
==========================================
  Files         202      202              
  Lines        7354     7358       +4     
  Branches     1301     1303       +2     
==========================================
  Hits         5151     5151              
- Misses       2180     2184       +4     
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmhobbs jmhobbs added patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged labels Jan 31, 2025
@jmhobbs jmhobbs added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit 7d3015c Jan 31, 2025
22 of 26 checks passed
@jmhobbs jmhobbs deleted the jmhobbs/cap-2683-turbosnap-not-working-with-rsbuild branch January 31, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants