Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for accessibility change counts in UI #1145

Merged

Conversation

jmhobbs
Copy link
Contributor

@jmhobbs jmhobbs commented Jan 23, 2025

Not yet connected to anything, but stubbed out the UI.

📦 Published PR as canary version: 11.25.3--canary.1145.13055748129.0

✨ Test out this PR locally via:

npm install chromatic@11.25.3--canary.1145.13055748129.0
# or 
yarn add chromatic@11.25.3--canary.1145.13055748129.0

@jmhobbs jmhobbs requested a review from a team January 23, 2025 15:56
@jmhobbs jmhobbs self-assigned this Jan 23, 2025
Copy link
Contributor

github-actions bot commented Jan 23, 2025

📦 Package Size: 5448 KB

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 73.07692% with 7 lines in your changes missing coverage. Please review.

Project coverage is 70.03%. Comparing base (e69d42b) to head (7af2d57).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
node-src/ui/messages/errors/buildHasChanges.ts 71.42% 4 Missing ⚠️
node-src/ui/messages/info/buildPassed.ts 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1145      +/-   ##
==========================================
- Coverage   70.05%   70.03%   -0.02%     
==========================================
  Files         202      202              
  Lines        7336     7353      +17     
  Branches     1297     1303       +6     
==========================================
+ Hits         5139     5150      +11     
- Misses       2174     2180       +6     
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@codykaup codykaup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmhobbs jmhobbs added patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged labels Jan 23, 2025
@jmhobbs jmhobbs marked this pull request as ready for review January 23, 2025 20:03
@jmhobbs jmhobbs added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit 71abbcc Jan 27, 2025
20 checks passed
@jmhobbs jmhobbs deleted the jmhobbs/cap-2647-update-cli-messaging-for-accessibility-diff branch January 27, 2025 15:52
@chromatic-ci-bot
Copy link
Collaborator

🚀 PR was released in v11.25.2 🚀

@chromatic-ci-bot chromatic-ci-bot added the released Verdict: This issue/pull request has been released label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged released Verdict: This issue/pull request has been released skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants