Merge pull request #1067 from chromaui/jmhobbs/cap-2250-clean-up-erro…

…rs-reported Do not capture config/option exceptions
chromaui · Oct 1, 2024 · b4fc0bf · b4fc0bf
2 parents 980e0c1 + 2e7250d
commit b4fc0bf
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/node-src/index.ts b/node-src/index.ts
@@ -162,7 +162,6 @@ export async function runAll(ctx: InitialContext) {
   ctx.log.info('');
 
   const onError = (err: Error | Error[]) => {
-    Sentry.captureException(err);
     ctx.log.info('');
     ctx.log.error(fatalError(ctx, [err].flat()));
     ctx.extraOptions?.experimental_onTaskError?.(ctx, {
@@ -198,7 +197,10 @@ export async function runAll(ctx: InitialContext) {
   }
 
   // Run these in parallel; neither should ever reject
-  await Promise.all([runBuild(ctx), checkForUpdates(ctx)]).catch(onError);
+  await Promise.all([runBuild(ctx), checkForUpdates(ctx)]).catch((error) => {
+    Sentry.captureException(error);
+    onError(error);
+  });
 
   if (!isE2EBuild(ctx.options) && [0, 1].includes(ctx.exitCode)) {
     await checkPackageJson(ctx);