Revert "Add ctx.projectMetadata.hasRouter"

This reverts commit 5b5eea5.
chromaui · Oct 30, 2024 · 961bf6f · 961bf6f
1 parent 6e22224
commit 961bf6f
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 73 deletions.
diff --git a/node-src/lib/getHasRouter.ts b/node-src/lib/getHasRouter.ts
diff --git a/node-src/tasks/storybookInfo.test.ts b/node-src/tasks/storybookInfo.test.ts
@@ -12,38 +12,8 @@ describe('storybookInfo', () => {
     const storybook = { version: '1.0.0', viewLayer: 'react', addons: [] };
     getStorybookInfo.mockResolvedValue(storybook);
 
-    const ctx = { packageJson: {} } as any;
+    const ctx = {} as any;
     await setStorybookInfo(ctx);
     expect(ctx.storybook).toEqual(storybook);
   });
-
-  it('sets hasRouter=true if there is a routing package in package.json', async () => {
-    const ctx = {
-      packageJson: {
-        dependencies: {
-          react: '^18',
-          'react-dom': '^18',
-          'react-router': '^6',
-        },
-      },
-    } as any;
-    await setStorybookInfo(ctx);
-    expect(ctx.projectMetadata.hasRouter).toEqual(true);
-  });
-
-  it('sets hasRouter=false if there is a routing package in package.json dependenices', async () => {
-    const ctx = {
-      packageJson: {
-        dependencies: {
-          react: '^18',
-          'react-dom': '^18',
-        },
-        devDependencies: {
-          'react-router': '^6',
-        },
-      },
-    } as any;
-    await setStorybookInfo(ctx);
-    expect(ctx.projectMetadata.hasRouter).toEqual(false);
-  });
 });
diff --git a/node-src/tasks/storybookInfo.ts b/node-src/tasks/storybookInfo.ts
@@ -4,7 +4,6 @@ import getStorybookInfo from '../lib/getStorybookInfo';
 import { createTask, transitionTo } from '../lib/tasks';
 import { Context } from '../types';
 import { initial, pending, success } from '../ui/tasks/storybookInfo';
-import { getHasRouter } from '../lib/getHasRouter';
 
 export const setStorybookInfo = async (ctx: Context) => {
   ctx.storybook = (await getStorybookInfo(ctx)) as Context['storybook'];
@@ -18,11 +17,6 @@ export const setStorybookInfo = async (ctx: Context) => {
     }
     Sentry.setContext('storybook', ctx.storybook);
   }
-
-  // Also get some project-level data for analytics
-  ctx.projectMetadata = {
-    hasRouter: getHasRouter(ctx.packageJson),
-  };
 };
 
 /**

diff --git a/node-src/types.ts b/node-src/types.ts
@@ -250,9 +250,6 @@ export interface Context {
     };
     mainConfigFilePath?: string;
   };
-  projectMetadata: {
-    hasRouter: boolean;
-  };
   storybookUrl?: string;
   announcedBuild: {
     id: string;