Merge pull request #1018 from chromaui/reuben/ap-4370-the-turbosnap-m…

…anifest-tracing-logic-doesnt-work test setting outOfSync to false
chromaui · Jul 31, 2024 · 0ce447e · 0ce447e
2 parents 4193a27 + 474041e
commit 0ce447e
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 8 deletions.
diff --git a/node-src/lib/findChangedDependencies.test.ts b/node-src/lib/findChangedDependencies.test.ts
@@ -17,7 +17,9 @@ const buildDepTree = vi.mocked(buildDepTreeFromFiles);
 
 beforeEach(() => {
   getRepositoryRoot.mockResolvedValue('/root');
-  findFilesFromRepositoryRoot.mockImplementation((file) => Promise.resolve(file.startsWith('**') ? [] : [file]));
+  findFilesFromRepositoryRoot.mockImplementation((file) =>
+    Promise.resolve(file.startsWith('**') ? [] : [file])
+  );
 });
 afterEach(() => {
   getRepositoryRoot.mockReset();
@@ -247,21 +249,29 @@ describe('findChangedDependencies', () => {
     await expect(findChangedDependencies(context)).resolves.toEqual(['react', 'lodash']);
 
     // Root manifest and lock files are checked
-    expect(buildDepTree).toHaveBeenCalledWith('/root', 'package.json', 'yarn.lock', true);
-    expect(buildDepTree).toHaveBeenCalledWith('/root', 'A.package.json', 'A.yarn.lock', true);
+    expect(buildDepTree).toHaveBeenCalledWith('/root', 'package.json', 'yarn.lock', true, false);
+    expect(buildDepTree).toHaveBeenCalledWith(
+      '/root',
+      'A.package.json',
+      'A.yarn.lock',
+      true,
+      false
+    );
 
     // Subpackage manifest and lock files are checked
     expect(buildDepTree).toHaveBeenCalledWith(
       '/root',
       'subdir/package.json',
       'subdir/yarn.lock',
-      true
+      true,
+      false
     );
     expect(buildDepTree).toHaveBeenCalledWith(
       '/root',
       'A.subdir/package.json',
       'A.subdir/yarn.lock',
-      true
+      true,
+      false
     );
   });
 
@@ -286,7 +296,8 @@ describe('findChangedDependencies', () => {
       '/root',
       'A.subdir/package.json',
       'A.yarn.lock', // root lockfile
-      true
+      true,
+      false
     );
   });
 
@@ -334,7 +345,8 @@ describe('findChangedDependencies', () => {
       '/root',
       'A.subdir/package.json',
       'A.subdir/package-lock.json',
-      true
+      true,
+      false
     );
   });
 });
diff --git a/node-src/lib/getDependencies.ts b/node-src/lib/getDependencies.ts
@@ -17,15 +17,23 @@ export const getDependencies = async (
     manifestPath,
     lockfilePath,
     includeDev = true,
+    strictOutOfSync = false,
   }: {
     rootPath: string;
     manifestPath: string;
     lockfilePath: string;
     includeDev?: boolean;
+    strictOutOfSync?: boolean;
   }
 ) => {
   try {
-    const headTree = await buildDepTreeFromFiles(rootPath, manifestPath, lockfilePath, includeDev);
+    const headTree = await buildDepTreeFromFiles(
+      rootPath,
+      manifestPath,
+      lockfilePath,
+      includeDev,
+      strictOutOfSync
+    );
     return flattenDependencyTree(headTree.dependencies);
   } catch (e) {
     ctx.log.debug({ rootPath, manifestPath, lockfilePath }, 'Failed to get dependencies');