Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Test Provider API instead of SidebarTop and SidebarBottom #342

Merged
merged 20 commits into from
Oct 23, 2024

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Oct 11, 2024

Updates the addon to use the new experimental_TEST_PROVIDER addon type that's coming in Storybook 8.4. When available, this API is used instead of the deprecated experimental_SIDEBAR_TOP and experimental_SIDEBAR_BOTTOM addon types.

The new API adds Visual tests as a test provider in the Testing Module at the bottom of the sidebar:

Screen.Recording.2024-10-11.at.08.53.38.mov

Most notifications have been removed in favor of showing a warning text in the Testing Module.

📦 Published PR as canary version: 3.0.0--canary.342.2071c8b.0

✨ Test out this PR locally via:

npm install @chromatic-com/storybook@3.0.0--canary.342.2071c8b.0
# or 
yarn add @chromatic-com/storybook@3.0.0--canary.342.2071c8b.0

@ghengeveld ghengeveld added release Auto: Create a `latest` release when merged major Auto: Increment the major version when merged labels Oct 11, 2024
src/manager.tsx Outdated Show resolved Hide resolved
@ghengeveld ghengeveld force-pushed the test-provider-integration branch from 7eaa3d4 to 8f8f922 Compare October 15, 2024 10:46
@ghengeveld ghengeveld force-pushed the test-provider-integration branch from 9ca2de2 to 4488efc Compare October 15, 2024 21:44
@ghengeveld ghengeveld force-pushed the test-provider-integration branch from 0495e87 to 898d4c4 Compare October 23, 2024 12:36
@ghengeveld ghengeveld force-pushed the test-provider-integration branch from caf088d to 2071c8b Compare October 23, 2024 12:57
@ghengeveld ghengeveld merged commit a613ed4 into main Oct 23, 2024
8 checks passed
@ghengeveld ghengeveld deleted the test-provider-integration branch October 23, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Auto: Increment the major version when merged release Auto: Create a `latest` release when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants