generated from storybookjs/addon-kit
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new Test Provider API instead of SidebarTop and SidebarBottom #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghengeveld
added
release
Auto: Create a `latest` release when merged
major
Auto: Increment the major version when merged
labels
Oct 11, 2024
yannbf
reviewed
Oct 11, 2024
ghengeveld
force-pushed
the
test-provider-integration
branch
from
October 15, 2024 10:46
7eaa3d4
to
8f8f922
Compare
ghengeveld
force-pushed
the
test-provider-integration
branch
from
October 15, 2024 21:44
9ca2de2
to
4488efc
Compare
… versions of Storybook
8 tasks
valentinpalkovic
approved these changes
Oct 17, 2024
ghengeveld
force-pushed
the
test-provider-integration
branch
from
October 23, 2024 12:36
0495e87
to
898d4c4
Compare
ghengeveld
force-pushed
the
test-provider-integration
branch
from
October 23, 2024 12:57
caf088d
to
2071c8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the addon to use the new
experimental_TEST_PROVIDER
addon type that's coming in Storybook 8.4. When available, this API is used instead of the deprecatedexperimental_SIDEBAR_TOP
andexperimental_SIDEBAR_BOTTOM
addon types.The new API adds Visual tests as a test provider in the Testing Module at the bottom of the sidebar:
Screen.Recording.2024-10-11.at.08.53.38.mov
Most notifications have been removed in favor of showing a warning text in the Testing Module.
📦 Published PR as canary version:
3.0.0--canary.342.2071c8b.0
✨ Test out this PR locally via:
npm install @chromatic-com/storybook@3.0.0--canary.342.2071c8b.0 # or yarn add @chromatic-com/storybook@3.0.0--canary.342.2071c8b.0