Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLD]: switch to Maturin for build, bundle Rust code with package #3766

Merged
merged 35 commits into from
Feb 18, 2025

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented Feb 11, 2025

Description of changes

  • maturin is used to build the main Python package rather than setuptools
  • build & publish to PyPi is its own workflow now and supports manual dispatches
  • sdist (source distribution) is tested to ensure the artifact has all files required to compile & run the package

Test plan

How are these changes tested?

Published a test package to test.pypi.org.

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@codetheweb codetheweb force-pushed the bld-maturin-ci branch 2 times, most recently from 05603d8 to 1467828 Compare February 12, 2025 05:15
@codetheweb codetheweb changed the title [BLD]: add workflow for Maturin [BLD]: switch to Maturin for build, bundle Rust code with package Feb 12, 2025
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

symbolic link, needed for the source distribution to build correctly (otherwise idl/ isn't included)

@codetheweb codetheweb marked this pull request as ready for review February 18, 2025 20:45
@codetheweb codetheweb requested a review from itaismith February 18, 2025 20:45
@codetheweb codetheweb enabled auto-merge (squash) February 18, 2025 21:23
@codetheweb codetheweb merged commit 95d8dfc into main Feb 18, 2025
112 checks passed
@codetheweb codetheweb deleted the bld-maturin-ci branch February 18, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants