-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BLD]: switch to Maturin for build, bundle Rust code with package #3766
Merged
+279
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
a73207f
to
761814e
Compare
a95775c
to
6a84ffa
Compare
236b7de
to
3315c14
Compare
f5838fd
to
8440b6f
Compare
8440b6f
to
151cde6
Compare
25b3791
to
05f0159
Compare
05f0159
to
cb36ac2
Compare
05603d8
to
1467828
Compare
1467828
to
6ac81bc
Compare
codetheweb
commented
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
symbolic link, needed for the source distribution to build correctly (otherwise idl/
isn't included)
codetheweb
commented
Feb 13, 2025
codetheweb
commented
Feb 18, 2025
itaismith
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
maturin
is used to build the main Python package rather thansetuptools
Test plan
How are these changes tested?
Published a test package to test.pypi.org.