-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Migrate away from MetadataReader and VectorReader #2942
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,8 @@ | |
from uuid import UUID | ||
|
||
from chromadb.db.base import SqlDB | ||
from chromadb.segment import SegmentManager, VectorReader | ||
from chromadb.segment import SegmentManager | ||
from chromadb.segment.impl.vector.local_hnsw import LocalHnswSegment | ||
|
||
topic_regex = r"persistent:\/\/(?P<tenant>.+)\/(?P<namespace>.+)\/(?P<topic>.+)" | ||
|
||
|
@@ -46,4 +47,4 @@ def trigger_vector_segments_max_seq_id_migration( | |
|
||
for collection_id in collection_ids_with_unmigrated_segments: | ||
# Loading the segment triggers the migration on init | ||
segment_manager.get_segment(UUID(collection_id), VectorReader) | ||
segment_manager.get_segment(UUID(collection_id), LocalHnswSegment) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is wrong. The segment could be LocalPersistentHnswSegment. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Update: the code is correct by coincidence. I'm going to rework on this PR a bit to re-introduce the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful!